[fix](udf) avoid exception when fail to find udf in replay logic #25965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
zhangstar333
approved these changes
Oct 26, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
pushed a commit
that referenced
this pull request
Oct 26, 2023
) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Oct 28, 2023
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
wsjz
pushed a commit
to wsjz/incubator-doris
that referenced
this pull request
Nov 19, 2023
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Aug 22, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 23, 2024
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` 
dataroaring
pushed a commit
that referenced
this pull request
Aug 23, 2024
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` 
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Aug 23, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 24, 2024
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When replaying
drop functionedit log, the function may not be found, causing runtime exception andFE will fail to start.
The function SHOULD be exist, but the reason is still unknown.
I change the logic to NOT throw exception if function is not found.
This is a workaround to make sure FE can start, and add some log for later debug.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...