-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](udf) avoid exception when fail to find udf in replay logic #25965
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` ![img_v3_02e0_3889b1de-583e-48ba-8e7f-48e1d3ae799g](https://github.com/user-attachments/assets/b0dbfefb-16f3-4dbb-8a00-f4773978ba01)
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` ![img_v3_02e0_3889b1de-583e-48ba-8e7f-48e1d3ae799g](https://github.com/user-attachments/assets/b0dbfefb-16f3-4dbb-8a00-f4773978ba01)
This PR completes #25965 to fix uncaught runtime exception when calling `org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction` ![img_v3_02e0_3889b1de-583e-48ba-8e7f-48e1d3ae799g](https://github.com/user-attachments/assets/b0dbfefb-16f3-4dbb-8a00-f4773978ba01)
Proposed changes
When replaying
drop function
edit log, the function may not be found, causing runtime exception andFE will fail to start.
The function SHOULD be exist, but the reason is still unknown.
I change the logic to NOT throw exception if function is not found.
This is a workaround to make sure FE can start, and add some log for later debug.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...