-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore](explain) Add algorithm item to VSORT explainition and modify dump_data of Block #38543
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42193 ms
|
TPC-DS: Total hot run time: 169050 ms
|
ClickBench: Total hot run time: 29.7 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dump_data of Block (apache#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
…dump_data of Block (#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
…dump_data of Block (#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
…dump_data of Block (apache#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
Proposed changes
Issue Number: close #xxx
VSORT
's explain string:before:
after:
Block::dump_data()
could work when the nullity of the type of data is different from that of column. it's useful when in some function call underdefault_implementation_for_nulls()