[chore](explain) Add algorithm item to VSORT explainition and modify dump_data of Block #38543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42193 ms |
TPC-DS: Total hot run time: 169050 ms |
ClickBench: Total hot run time: 29.7 s |
BiteTheDDDDt
approved these changes
Jul 31, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
…dump_data of Block (apache#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…dump_data of Block (#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…dump_data of Block (#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
…dump_data of Block (apache#38543) ## Proposed changes Issue Number: close #xxx 1. add algorithm record in `VSORT`'s explain string: before: ```sql | 1:VSORT(101) | | | order by: xxx | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` after: ```sql | 1:VSORT(101) | | | order by: xxx | | | algorithm: full sort | | | offset: 0 | | | distribute expr lists: | | | tuple ids: 2 | ``` 2. add a new parameter to make `Block::dump_data()` could work when the nullity of the type of data is different from that of column. it's useful when in some function call under `default_implementation_for_nulls()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
VSORT's explain string:before:
after:
Block::dump_data()could work when the nullity of the type of data is different from that of column. it's useful when in some function call underdefault_implementation_for_nulls()