Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]Put generateSerializedResult in try catch to avoid insufficient memory caused by excessive data size #202

Merged
merged 1 commit into from
May 15, 2024

Conversation

lxwcodemonkey
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

When a batch of data is too large, it will cause OOM when generatingSerializedResult, but also it is not in trycatch, a batch of data cannot be divided.
cf05a261a8f4d2338b9cfd2fca9f2af

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…ficient memory caused by excessive data volume
@lxwcodemonkey lxwcodemonkey changed the title [Improvement]Put generateSerializedResult in try catch to avoid insufficient memory caused by excessive data volume [Improvement]Put generateSerializedResult in try catch to avoid insufficient memory caused by excessive data size May 8, 2024
@lxwcodemonkey
Copy link
Contributor Author

@JNSimba Could you help me to have a look? thanks!

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 61852e8 into apache:master May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants