Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix data duplication issue when retrying #201

Merged
merged 1 commit into from
May 8, 2024

Conversation

gnehil
Copy link
Contributor

@gnehil gnehil commented May 7, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

After loading retry is enabled, the batch needs to be cached by adding the next object of the iterator to the ArrayBuffer. Since the memory of the next object is reused, objects with the same memory address are added to the array multiple times. , so when retrying to traverse the buffer, all the objects read are the last objects obtained by the iterator.
Fix: copy the next object of the iterator and save the copy in the buffer.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 5c7cf93 into apache:master May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants