Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow App using inappbrowser to be hosted in a cross-origin iframe #669

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Allow App using inappbrowser to be hosted in a cross-origin iframe #669

merged 1 commit into from
Apr 14, 2020

Conversation

csware
Copy link
Contributor

@csware csware commented Apr 14, 2020

Platforms affected

Browsers such as Firefox, Chrome

Motivation and Context

Allow App using inappbrowser to be hosted in a cross-origin iframe

closes GH-419

Description

Prevent an uncaught exception.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick chat via Slack: The Ripple emulator is long retired. Since we've already have breaking changes in the master you can just remove the whole //special patch block. It would be good if you can prefix your commit message with breaking so we know what breaking changes will be in the next major.

Thanks for bringing attention to this!

@csware
Copy link
Contributor Author

csware commented Apr 14, 2020

I'd prefer to have a fix in the old stable version as well.

… apps using inappbrowser to be hosted in a cross-origin iframe

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@timbru31
Copy link
Member

The next release will be a major one - I highly doubt that we will do a minor/patch release.

@timbru31 timbru31 merged commit 9b6b229 into apache:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App using inappbrowser cannot be hosted in a cross-domain iframe
2 participants