Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) Defensive code to prevent NULL reference exceptions for async #503

Merged
merged 2 commits into from
Jan 4, 2020

Conversation

alexyazvinsky
Copy link
Contributor

@alexyazvinsky alexyazvinsky commented Jul 9, 2019

Platforms affected

Android

Motivation and Context

Defensive code to prevent NULL reference exceptions for async

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz NiklasMerz changed the title Defensive code to prevent NULL reference exceptions for async (android) Defensive code to prevent NULL reference exceptions for async Dec 31, 2019
@NiklasMerz NiklasMerz added this to the 3.2.0 milestone Dec 31, 2019
src/android/InAppBrowser.java Outdated Show resolved Hide resolved
src/android/InAppBrowser.java Outdated Show resolved Hide resolved
src/android/InAppBrowser.java Outdated Show resolved Hide resolved
@NiklasMerz
Copy link
Member

NiklasMerz commented Jan 2, 2020

I like to live dangerous and rebased this PR and did the suggested changes. I hope I did not mess anything up. A backup is in my fork here

That's what I did:

  • rebased the PR to latest master
  • did an interactive rebase to squash the two relevant commits and drop the reverted changes
  • changed the author to @alexyazvinsky and pushed this as a signed commit since I did this
  • Did the suggested changes separately

I hope that makes this PR better to read and follows the Apache guidelines. We should merge this and not squash merge to make the authors and history clear.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants