Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12941: update typings #223

Closed
wants to merge 1 commit into from
Closed

CB-12941: update typings #223

wants to merge 1 commit into from

Conversation

timbru31
Copy link
Member

Platforms affected

n/a - development via TypeScript

What does this PR do?

Updates the typings to match the latest published version on DefinitelyTyped.
See DefinitelyTyped/DefinitelyTyped#17192 and https://stackoverflow.com/q/42095516/1902598

What testing has been done on this change?

Project compiles again ;)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • n/a: Added automated test coverage as appropriate for this change.

@timbru31
Copy link
Member Author

timbru31 commented Feb 6, 2018

@infil00p any chance for a review? because the @types removed the correct typings in DefinitelyTyped/DefinitelyTyped#22305 and these are broken.
I'm happy to update these to the most recent v2.x release, too.

@nicolashenry
Copy link
Contributor

nicolashenry commented Mar 23, 2018

@timbru31 Can you update your PR to the latest available version from DefinitivelyTyped?

@timbru31
Copy link
Member Author

@nicolashenry Sure! Will do it in the next days :)

@timbru31
Copy link
Member Author

I've had to re-open this PR as #267, since I've had deleted the fork in the meantime.

@timbru31 timbru31 closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants