Merge pull request #670 from apache/feature/remove-outdated-rsa-shm

Remove broken discovery_shm implementation.

.github/workflows/coverity-scan.yml

@@ -46,7 +46,6 @@ jobs:
             -DBUILD_EXPERIMENTAL=ON
             -DENABLE_TESTING=ON
             -DRSA_JSON_RPC=ON
-            -DRSA_SHM=ON
             -DRSA_REMOTE_SERVICE_ADMIN_SHM_V2=ON
             -DSHELL_BONJOUR=ON
         run: |

.github/workflows/ubuntu.yml

@@ -144,7 +144,6 @@ jobs:
           -DBUILD_EXPERIMENTAL=ON
           -DENABLE_TESTING=ON
           -DRSA_JSON_RPC=ON
-          -DRSA_SHM=ON
           -DRSA_REMOTE_SERVICE_ADMIN_SHM_V2=ON
           -DENABLE_TESTING_ON_CI=ON
           -DCMAKE_BUILD_TYPE=${{ matrix.type }}

bundles/remote_services/CMakeLists.txt

@@ -31,11 +31,6 @@ if (REMOTE_SERVICE_ADMIN)
     add_subdirectory(rsa_rpc_json)
     add_subdirectory(remote_service_admin_shm_v2)
 
-    celix_subproject(RSA_SHM "Option to enable building the Discovery (SHM) bundle" OFF)
-    if (RSA_SHM)
-        add_subdirectory(discovery_shm)
-    endif ()
-
     if (BUILD_RSA_DISCOVERY_ETCD AND BUILD_RSA_REMOTE_SERVICE_ADMIN_DFI AND BUILD_SHELL AND BUILD_SHELL_TUI AND BUILD_LOG_SERVICE AND BUILD_LAUNCHER)
         add_celix_container(remote-services-dfi
                 LAUNCHER Celix::launcher

bundles/remote_services/README.md

@@ -54,26 +54,10 @@ Provides a RSA implementation that uses JSON to marshal requests and HTTP as tra
 | **Configuration** | `RSA_PORT`: defines the port on which the HTTP server should listen for incoming requests. Defaults to port `8888`; |
 | | `ENDPOINTS`: defines the location in which service endpoints and/or proxies can be found. Defaults to `endpoints` in the current working directory |
 
-#### Shared memory (SHM)
-
-Provides a RSA implementation that uses shared memory for its remote method invocation. Note that this only works when all remote services are located on the same machine.
-
-| **Bundle** | `remote_service_admin_shm.zip` |
-|--|--|
-| **Configuration** | `ENDPOINTS`: defines the location in which service endpoints and/or proxies can be found. Defaults to `endpoints` in the current working directory |
-
 ### Discovery
 
 Actively discovers the presence of remote exported services and provides information about local exported services, as given by the Topology Manager, to others.
 
-#### Shared memory (SHM) based discovery
-
-Provides service discovery for the RSA SHM implementation.
-
-| **Bundle** | `discovery_shm.zip` |
-|--|--|
-| **Configuration** | *None* |
-
 #### Configured discovery
 
 Provides a service discovery with preconfigured discovery endpoints, allowing a static mesh of nodes for remote service invocation to be created. The configured discovery bundle in Celix is compatible with the configured discovery implementation provided by [Amdatu Remote](https://amdatu.atlassian.net/wiki/display/AMDATUDEV/Amdatu+Remote).
@@ -162,11 +146,9 @@ Also the following libraries are required for building and/or using the Remote S
 ## RSA Bundles
 
 * [Remote Service Admin DFI](remote_service_admin_dfi) - A Dynamic Function Interface (DFI) implementation of the RSA.
-* [Remote Service Admin SHM](remote_service_admin_shm) - A shared memory implementation of the RSA.
 * [Topology Manager](topology_manager) - A (scoped) RSA Topology Manager implementation.
 * [Discovery Configured](discovery_configured) - A RSA Discovery implementation using static configuration (xml).
 * [Discovery Etcd](discovery_etcd/README.md) - A RSA Discovery implementation using etcd.
-* [Discovery SHM](discovery_shm) - A RSA Discovery implementation using shared memory.
 
 
 ## Notes