-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc doc and infra fix found in 2.55.0 release #30702
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,11 +13,8 @@ on: | |
RC: | ||
description: Integer RC version for the release (e.g. 3 for RC3) | ||
required: true | ||
PYPI_USER: | ||
description: PyPi username to perform the upload with | ||
required: true | ||
PYPI_PASSWORD: | ||
description: PyPi password to perform the upload with | ||
PYPI_API_TOKEN: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. feeding username and password result in 403 ... legacy authentication rejected The finalize release workflow already used API token. Align deploy rc workflow to it |
||
description: PyPi API token to perform the PyPi upload with | ||
required: true | ||
|
||
env: | ||
|
@@ -32,8 +29,8 @@ jobs: | |
- name: Mask PyPi id/password | ||
run: | | ||
# Workaround for Actions bug - https://github.com/actions/runner/issues/643 | ||
PYPI_PASSWORD=$(jq -r '.inputs.PYPI_PASSWORD' $GITHUB_EVENT_PATH) | ||
echo "::add-mask::$PYPI_PASSWORD" | ||
PYPI_API_TOKEN=$(jq -r '.inputs.PYPI_API_TOKEN' $GITHUB_EVENT_PATH) | ||
echo "::add-mask::$PYPI_API_TOKEN" | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Setup environment | ||
|
@@ -87,4 +84,4 @@ jobs: | |
echo "Will upload the following files to PyPI:" | ||
ls | ||
|
||
twine upload * -u "${{ github.event.inputs.PYPI_USER }}" -p "${{ github.event.inputs.PYPI_PASSWORD }}" | ||
twine upload * -u __token__ -p "${{ github.event.inputs.PYPI_API_TOKEN }}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,9 +174,7 @@ def tearDown(self): | |
if self.instance.exists(): | ||
self.instance.delete() | ||
|
||
# TODO(https://github.com/apache/beam/issues/29076): Reenable this test | ||
# once BigTable issues are fixed. | ||
@pytest.mark.it_postcommit_sickbay | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This reverts #29197 as Python PostCommit sickbay has been passing this test, and the original todo issue is closed |
||
@pytest.mark.it_postcommit | ||
def test_bigtable_write(self): | ||
number = self.number | ||
pipeline_args = self.test_pipeline.options_list | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java11 and 17 precommits were moved to postcommit (line 292 of this file), and now only java(java8) and java21 run on precommit