Misc doc and infra fix found in 2.55.0 release #30702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
commented
Mar 21, 2024
| @@ -215,8 +215,7 @@ PreCommit Jobs run in a schedule and also get triggered in a PR if relevant sour | |||
| | [ PreCommit Java Debezium IO Direct ](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Debezium_IO_Direct.yml) | N/A |`Run Java_Debezium_IO_Direct PreCommit`| [](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Debezium_IO_Direct.yml?query=event%3Aschedule) | | |||
| | [ PreCommit Java ElasticSearch IO Direct ](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml) | N/A |`Run Java_ElasticSearch_IO_Direct PreCommit`| [](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml?query=event%3Aschedule) | | |||
| | [ PreCommit Java Examples Dataflow ](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Examples_Dataflow.yml) | N/A |`Run Java_Examples_Dataflow PreCommit`| [](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Examples_Dataflow.yml?query=event%3Aschedule) | | |||
| | [ PreCommit Java Examples Dataflow Java11 ](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Examples_Dataflow_Java11.yml) | N/A | `Run Java_Examples_Dataflow_Java11 PreCommit` | [](https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Examples_Dataflow_Java11.yml?query=event%3Aschedule) | | |||
There was a problem hiding this comment.
java11 and 17 precommits were moved to postcommit (line 292 of this file), and now only java(java8) and java21 run on precommit
| required: true | ||
| PYPI_PASSWORD: | ||
| description: PyPi password to perform the upload with | ||
| PYPI_API_TOKEN: |
There was a problem hiding this comment.
feeding username and password result in 403 ... legacy authentication rejected
The finalize release workflow already used API token. Align deploy rc workflow to it
* Release doc fixes * Update workflow README for newly added workflows * Do not trigger sickbay test in release verification * Remove redundant shadowjar validation exclusions in harness build.gradle * Use API token in deploy_rc_pypi action, in alignment with finalize release * Unsickbay test_bigtable_write
Abacn
commented
Mar 21, 2024
| @@ -174,9 +174,7 @@ def tearDown(self): | |||
| if self.instance.exists(): | |||
| self.instance.delete() | |||
|
|
|||
| # TODO(https://github.com/apache/beam/issues/29076): Reenable this test | |||
| # once BigTable issues are fixed. | |||
| @pytest.mark.it_postcommit_sickbay | |||
There was a problem hiding this comment.
This reverts #29197 as Python PostCommit sickbay has been passing this test, and the original todo issue is closed
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
hjtran
pushed a commit
to hjtran/beam
that referenced
this pull request
Apr 4, 2024
* Release doc fixes * Update workflow README for newly added workflows * Do not trigger sickbay test in release verification * Remove redundant shadowjar validation exclusions in harness build.gradle * Use API token in deploy_rc_pypi action, in alignment with finalize release * Unsickbay test_bigtable_write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release doc fixes
Update workflow README for newly added workflows
Do not trigger sickbay test in release verification
Remove redundant shadowjar validation exclusions in harness build.gradle
Use API token in deploy_rc_pypi action, in alignment with finalize release
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.