-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions #8158
Conversation
eece673
to
f1dbfbe
Compare
@wesm This pr fails in windows with a LINK error during build (during creating the unit test binary). Do you have an idea why this is failing in windows. Or is there any remote windows machine for arrow devs where I can try out and investigate myself (unfortunately I don't have a personal windows machine)? |
Either you need to statically-link these symbols (or include them with the .cc files / object code for the unit test) or add an appropriate export annotation for the functions so they will link from the DLL |
d5f4e32
to
dc97693
Compare
Thanks @wesm |
d4608a9
to
356c300
Compare
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the #8158 PR to change the function output to match the Java language patterns. Closes #9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <anthony@simbioseventures.com> Co-authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <anthony@simbioseventures.com> Co-authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <anthony@simbioseventures.com> Co-authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <anthony@simbioseventures.com> Co-authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <anthony@simbioseventures.com> Co-authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
No description provided.