GH-44273: [C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility #44275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
There are a lot of failing CI builds. |
|
Oh, sorry. I needed to update more expected values... |
…bility Most environments such as Python, Node.js, PostgreSQL and MySQL accepts `0.E+1` but some environments such as Ruby don't accept `0.E+1`. More environments accept `0.0E+1` or `0E+1` than `0.E+1`. Use `0E+1` not `0.E+1` for broader compatibility.
kou
force-pushed
the
cpp-decimal-not-omit-fractional
branch
from
887bd76
to
3f25f22
Compare
|
I'll merge this in a few days if nobody objects this. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d4516c5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Most environments such as Python, Node.js, PostgreSQL and MySQL accepts
0.E+1but some environments such as Ruby don't accept0.E+1. More environments accept0.0E+1or0E+1than0.E+1.What changes are included in this PR?
Use
0E+1not0.E+1for broader compatibility.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
0E+1not0.E+1for broader compatibility #44273