-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44065: [Java] Implement C Data Interface for RunEndEncodedVector #44241
base: main
Are you sure you want to change the base?
Conversation
ViggoC
commented
Sep 26, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- GitHub Issue: [Java] Request to support Run-End Encoded Layout in Java C Data interface #44065
@ViggoC it would be better to add a test here as well https://github.com/apache/arrow/blob/main/java/c/src/test/python/integration_tests.py |
@vibhatha Your response is really quickly. I am still trying to understand your PR #41967, as well as how to run tests. If you could give me some guidance, it would be of great help. |
Right, so there are few things we have to do here. For integration tests, you need to make sure to use One more important thing is the If you have any questions, please ask here. And thanks for pushing this effort. |
cc @raulcd |
@@ -770,6 +771,17 @@ public void testStructVector() { | |||
} | |||
} | |||
|
|||
@Test | |||
public void testRunEndEncodedVector() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we also add a test for an empty REE Vector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, see testEmptyRunEndEncodedVector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only went through one quick pass, I will review again.
@github-actions crossbow submit -g java |
Revision: b34aca3 Submitted crossbow builds: ursacomputing/crossbow @ actions-302154c076 |