Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++][Acero] Replace acero-specific append avx2 cmake macro with generic one #44240

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

zanmato1984
Copy link
Collaborator

Rationale for this change

Macro append_acero_runtime_avx2_src is duplicated with generic append_runtime_avx2_src.

What changes are included in this PR?

Remove append_acero_runtime_avx2_src and replace it with append_runtime_avx2_src.

Are these changes tested?

CI should be enough.

Are there any user-facing changes?

None.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@zanmato1984
Copy link
Collaborator Author

Hi @kou @pitrou , would you mind to take a look? Thanks.

@zanmato1984
Copy link
Collaborator Author

I assume cmake-only changes can be a minor PR. If I'm wrong, please let me known and I will file an issue for it. Thanks.

@pitrou pitrou changed the title MINRO: [C++][Acero] Replace acero-specific append avx2 cmake macro with generic one MINOR: [C++][Acero] Replace acero-specific append avx2 cmake macro with generic one Sep 26, 2024
@pitrou
Copy link
Member

pitrou commented Sep 26, 2024

@github-actions crossbow submit -g cpp

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's just ensure this doesn't break CI builds

@github-actions github-actions bot removed the awaiting review Awaiting review label Sep 26, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 26, 2024
Copy link

Revision: 2f1d594

Submitted crossbow builds: ursacomputing/crossbow @ actions-cf5eb235b2

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou merged commit a576421 into apache:main Sep 26, 2024
41 of 42 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Sep 26, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a576421.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants