Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43878: [Go][Release] Remove Go related codes from our release scripts #44172

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Sep 19, 2024

Rationale for this change

The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.

What changes are included in this PR?

Remove go related release scripts from apache/arrow

Are these changes tested?

The source verification is tested via archery

Are there any user-facing changes?

Yes, Go will not be releases as part of Apache Arrow anymore.

Copy link

⚠️ GitHub issue #43878 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@zeroshade will we have to update these urls to point here https://pkg.go.dev/github.com/apache/arrow-go/go/v18 once we release?

Go <https://pkg.go.dev/github.com/apache/arrow/go/v18>

[Go](https://pkg.go.dev/github.com/apache/arrow/go/v18) <br>

Is there any way to point to latest so we don't have to bump the release on arrow when we release arrow-go?

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@github-actions crossbow submit verify-rc-source-*

Copy link

Revision: 42dd7f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-61cfbe58a4

Task Status
verify-rc-source-cpp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-csharp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-integration-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-js-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
verify-rc-source-windows GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@kou
Copy link
Member

kou commented Sep 19, 2024

How about creating https://arrow.apache.org/go/ as the canonical Apache Arrow Go website?
We can link to https://pkg.go.dev/github.com/apache/arrow-go/v${LATEST} from the URL.

@raulcd
Copy link
Member Author

raulcd commented Sep 23, 2024

How about creating https://arrow.apache.org/go/ as the canonical Apache Arrow Go website?

How can I do this? @kou

@raulcd raulcd marked this pull request as ready for review September 23, 2024 09:41
@kou
Copy link
Member

kou commented Sep 24, 2024

We can use .asf.yaml:

With the publish: configuration in apache/arrow-go's .asf.yaml, we can deploy the asf-site branch content to https://arrow.apache.org/go/ .

@kou
Copy link
Member

kou commented Sep 24, 2024

apache/arrow-go#139

@raulcd
Copy link
Member Author

raulcd commented Oct 3, 2024

@kou are you ok for me merging this? The docs, once deployed with the release, will point to https://arrow.apache.org/go/ but this can be merged as is so we can unblock removing the go code from this repo.

@kou
Copy link
Member

kou commented Oct 3, 2024

Yes!

Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raulcd raulcd merged commit aee3078 into apache:main Oct 3, 2024
12 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Oct 3, 2024
@raulcd raulcd deleted the GH-43878 branch October 3, 2024 09:56
@github-actions github-actions bot added the awaiting changes Awaiting changes label Oct 3, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aee3078.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants