You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug, including details regarding any error messages, version, and platform.
When going through a POC with Meson I noticed the following types of warnings appearing in a standard build:
../src/arrow/util/utf8_internal.h:185:44: warning: this statement may fall through [-Wimplicit-fallthrough=]
185 | state = internal::ValidateOneUTF8Byte(data[size - 7], state);|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/util/utf8_internal.h:186:5: note: here
186 |case 6:
| ^~~~
../src/arrow/util/utf8_internal.h:187:44: warning: this statement may fall through [-Wimplicit-fallthrough=]
187 | state = internal::ValidateOneUTF8Byte(data[size - 6], state);|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/util/utf8_internal.h:188:5: note: here
188 |case 5:
Should be easy enough to clean up
Component(s)
C++
The text was updated successfully, but these errors were encountered:
### Rationale for this change
Helps clean up warnings, and at least one of these looks like a subtle bug that may confuse developers
### What changes are included in this PR?
Added break statements where case statements were previously falling through
### Are these changes tested?
Builds cleanly
### Are there any user-facing changes?
No
* GitHub Issue: #41891
Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Will Ayd <william.ayd@icloud.com>
Describe the bug, including details regarding any error messages, version, and platform.
When going through a POC with Meson I noticed the following types of warnings appearing in a standard build:
Should be easy enough to clean up
Component(s)
C++
The text was updated successfully, but these errors were encountered: