-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] ORC Reader aborts when timezone file is missing #40633
Comments
@wgtmac will improve this. |
This seems to be related to the installed version of tz database on the test machine. I checked my laptop and the path |
That file does not exist for me. This is running popOS 22.04 |
Could you try installing the |
I don't see that package for 22.04 - I think first appeared in 23.04? |
Oh, sorry. Could you install |
It is already installed - |
Hmm. |
Ah OK - interesting indeed. That must have been deleted off of my system somehow, but I do see that in a recovery OS. Happy to close this issue if we want to chalk it up to an unsupported system configuration |
### What changes were proposed in this pull request? Enable TestTimezone.testMissingTZDB unit test to run on Windows. ### Why are the changes needed? When /usr/share/zoneinfo is unavailable and TZDIR env is unset, creating C++ ORC reader will crash on Windows. We need to better deal with this case. See context from the Apache Arrow community: apache/arrow#36026 and apache/arrow#40633 ### How was this patch tested? Make sure the test passes on Windows. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1856 from wgtmac/win_tz_test. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? Enable TestTimezone.testMissingTZDB unit test to run on Windows. ### Why are the changes needed? When /usr/share/zoneinfo is unavailable and TZDIR env is unset, creating C++ ORC reader will crash on Windows. We need to better deal with this case. See context from the Apache Arrow community: apache/arrow#36026 and apache/arrow#40633 ### How was this patch tested? Make sure the test passes on Windows. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1856 from wgtmac/win_tz_test. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
I also observed pyarrow breaking while processing ORC files, due to inexistent IANA keys. Those were observed on running the pandas test suit locally, but just trying to read some pre-existent ORC files completely broke python and ipython. My setup includes Ubuntu Mantic, Python 3.11 and At least in my case, installing |
I've been debugging this issue and independently found the same solution - installing
|
Describe the bug, including details regarding any error messages, version, and platform.
This is an upstream report of pandas-dev/pandas#56292
I noticed when running the pandas test suite I was getting this error:
The workaround is to create that timezone file:
Although I think the error should be handled more gracefully than via abort
Component(s)
Python
The text was updated successfully, but these errors were encountered: