Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][CI] Fix or suppress spurious errorprone warnings #39330

Closed
danepitkin opened this issue Dec 20, 2023 · 9 comments · Fixed by #39529
Closed

[Java][CI] Fix or suppress spurious errorprone warnings #39330

danepitkin opened this issue Dec 20, 2023 · 9 comments · Fixed by #39529

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

Search for errorprone warnings in this log file for an example: https://github.com/apache/arrow/actions/runs/7279758208/job/19836729983?pr=39329

Auto-generated code such as Arrow format can be suppressed. For hand-written code, let's try to fix them.

Component(s)

Java

@vibhatha
Copy link
Collaborator

take

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 5, 2024

@danepitkin I took a look at this and seems like there are plenty of cases we need to improve. I will work on this.
Thanks for noting this. I noted this a few times when looking into CIs in the last few days.

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 9, 2024

@lidavidm I am working on fixing the warnings, and there is a warning for an unused variable context, https://github.com/apache/arrow/blob/main/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java#L479-L628

[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[604,35] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'error(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[600,36] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'cancel(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[525,34] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'echo(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[513,42] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'metadataOnly(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[558,39] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'transform(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[479,57] [UnusedVariable] The parameter 'reader' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'doGet(context, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[600,58] [UnusedVariable] The parameter 'reader' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'cancel(context, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[496,35] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'doPut(reader, writer);'?
[WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[479,35] [UnusedVariable] The parameter 'context' is never read.
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean 'doGet(reader, writer);'?

Should we ignore this warning for now? I assume there should be a solid reason for introducing context to those functions.

@lidavidm
Copy link
Member

lidavidm commented Jan 9, 2024

You can remove the parameter.

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 10, 2024

Edited: (please ignore)

Also @lidavidm @danepitkin should we make a single PR for all modules or a PR per module? Any preference?

@vibhatha
Copy link
Collaborator

I am observing these very regularly, are these expected or maybe I have not configured things properly for Flight?
Though it doen't fail the build.

[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.113 s -- in org.apache.arrow.driver.jdbc.ConnectionTest
[INFO] Running org.apache.arrow.driver.jdbc.ResultSetTest
05:32:24.710 [main] INFO  o.a.a.d.jdbc.FlightServerTestRule - Started org.apache.arrow.flight.FlightServer as org.apache.arrow.flight.FlightServer@77724cbe
05:32:24.843 [main] ERROR o.a.a.f.auth2.ClientHandshakeWrapper - Failed on completing future
org.apache.arrow.flight.FlightRuntimeException: org.apache.arrow.flight.FlightRuntimeException: UNAVAILABLE: io exception
Channel Pipeline: [SslHandler#0, ProtocolNegotiators$ClientTlsHandler#0, WriteBufferingAndExceptionHandler#0, DefaultChannelPipeline$TailContext#0]
	at org.apache.arrow.flight.CallStatus.toRuntimeException(CallStatus.java:131)
	at org.apache.arrow.flight.grpc.StatusUtils.fromGrpcRuntimeException(StatusUtils.java:165)
	at org.apache.arrow.flight.grpc.StatusUtils.fromThrowable(StatusUtils.java:186)
	at org.apache.arrow.flight.auth2.ClientHandshakeWrapper.doClientHandshake(ClientHandshakeWrapper.java:59)
	at org.apache.arrow.flight.FlightClient.handshake(FlightClient.java:213)
	at org.apache.arrow.driver.jdbc.client.utils.ClientAuthenticationUtils.getAuthenticate(ClientAuthenticationUtils.java:105)
	at org.apache.arrow.driver.jdbc.client.utils.ClientAuthenticationUtils.getAuthenticate(ClientAuthenticationUtils.java:93)
	at org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandler$Builder.build(ArrowFlightSqlClientHandler.java:801)
	at org.apache.arrow.driver.jdbc.ArrowFlightConnection.createNewClientHandler(ArrowFlightConnection.java:114)
	at org.apache.arrow.driver.jdbc.ArrowFlightConnection.createNewConnection(ArrowFlightConnection.java:88)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDriver.connect(ArrowFlightJdbcDriver.java:89)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource.getConnection(ArrowFlightJdbcDataSource.java:97)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource.getConnection(ArrowFlightJdbcDataSource.java:90)
	at org.apache.arrow.driver.jdbc.ConnectionTlsTest.testGetAuthenticatedEncryptedConnectionWithKeyStoreBadPassword(ConnectionTlsTest.java:255)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.apache.arrow.driver.jdbc.FlightServerTestRule$1.evaluate(FlightServerTestRule.java:165)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
	at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
	at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:56)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.lambda$execute$1(JUnitPlatformProvider.java:191)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:186)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:148)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:118)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: javax.net.ssl.SSLHandshakeException: General OpenSslEngine problem
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.handshakeException(ReferenceCountedOpenSslEngine.java:1945)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.wrap(ReferenceCountedOpenSslEngine.java:852)
	at java.base/javax.net.ssl.SSLEngine.wrap(SSLEngine.java:564)
	at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:1131)
	at io.netty.handler.ssl.SslHandler.wrapNonAppData(SslHandler.java:975)
	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1511)
	at io.netty.handler.ssl.SslHandler.unwrapNonAppData(SslHandler.java:1429)
	at io.netty.handler.ssl.SslHandler.access$1800(SslHandler.java:171)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.resumeOnEventExecutor(SslHandler.java:1820)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.access$2000(SslHandler.java:1711)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner$2.run(SslHandler.java:1872)
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:388)
	at java.base/sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:271)
	at java.base/sun.security.validator.Validator.validate(Validator.java:256)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:284)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:144)
	at io.netty.handler.ssl.EnhancingX509ExtendedTrustManager.checkServerTrusted(EnhancingX509ExtendedTrustManager.java:69)
	at io.netty.handler.ssl.ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerifyCallback.verify(ReferenceCountedOpenSslClientContext.java:235)
	at io.netty.handler.ssl.ReferenceCountedOpenSslContext$AbstractCertificateVerifier.verify(ReferenceCountedOpenSslContext.java:790)
	at io.netty.internal.tcnative.CertificateVerifierTask.runTask(CertificateVerifierTask.java:36)
	at io.netty.internal.tcnative.SSLTask.run(SSLTask.java:48)
	at io.netty.internal.tcnative.SSLTask.run(SSLTask.java:42)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.runAndResetNeedTask(ReferenceCountedOpenSslEngine.java:1534)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.access$700(ReferenceCountedOpenSslEngine.java:96)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine$TaskDecorator.run(ReferenceCountedOpenSslEngine.java:1509)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.run(SslHandler.java:1889)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	... 1 common frames omitted
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:146)
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:127)
	at java.base/java.security.cert.CertPathBuilder.build(CertPathBuilder.java:297)
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:383)
	... 17 common frames omitted
05:32:24.844 [main] ERROR o.a.a.f.auth2.ClientHandshakeWrapper - Failed with unknown
org.apache.arrow.flight.FlightRuntimeException: org.apache.arrow.flight.FlightRuntimeException: UNAVAILABLE: io exception
Channel Pipeline: [SslHandler#0, ProtocolNegotiators$ClientTlsHandler#0, WriteBufferingAndExceptionHandler#0, DefaultChannelPipeline$TailContext#0]
	at org.apache.arrow.flight.CallStatus.toRuntimeException(CallStatus.java:131)
	at org.apache.arrow.flight.grpc.StatusUtils.fromGrpcRuntimeException(StatusUtils.java:165)
	at org.apache.arrow.flight.grpc.StatusUtils.fromThrowable(StatusUtils.java:186)
	at org.apache.arrow.flight.auth2.ClientHandshakeWrapper.doClientHandshake(ClientHandshakeWrapper.java:59)
	at org.apache.arrow.flight.FlightClient.handshake(FlightClient.java:213)
	at org.apache.arrow.driver.jdbc.client.utils.ClientAuthenticationUtils.getAuthenticate(ClientAuthenticationUtils.java:105)
	at org.apache.arrow.driver.jdbc.client.utils.ClientAuthenticationUtils.getAuthenticate(ClientAuthenticationUtils.java:93)
	at org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandler$Builder.build(ArrowFlightSqlClientHandler.java:801)
	at org.apache.arrow.driver.jdbc.ArrowFlightConnection.createNewClientHandler(ArrowFlightConnection.java:114)
	at org.apache.arrow.driver.jdbc.ArrowFlightConnection.createNewConnection(ArrowFlightConnection.java:88)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDriver.connect(ArrowFlightJdbcDriver.java:89)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource.getConnection(ArrowFlightJdbcDataSource.java:97)
	at org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource.getConnection(ArrowFlightJdbcDataSource.java:90)
	at org.apache.arrow.driver.jdbc.ConnectionTlsTest.testGetAuthenticatedEncryptedConnectionWithKeyStoreBadPassword(ConnectionTlsTest.java:255)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.apache.arrow.driver.jdbc.FlightServerTestRule$1.evaluate(FlightServerTestRule.java:165)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
	at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
	at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:56)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.lambda$execute$1(JUnitPlatformProvider.java:191)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:186)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:148)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:118)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: javax.net.ssl.SSLHandshakeException: General OpenSslEngine problem
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.handshakeException(ReferenceCountedOpenSslEngine.java:1945)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.wrap(ReferenceCountedOpenSslEngine.java:852)
	at java.base/javax.net.ssl.SSLEngine.wrap(SSLEngine.java:564)
	at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:1131)
	at io.netty.handler.ssl.SslHandler.wrapNonAppData(SslHandler.java:975)
	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1511)
	at io.netty.handler.ssl.SslHandler.unwrapNonAppData(SslHandler.java:1429)
	at io.netty.handler.ssl.SslHandler.access$1800(SslHandler.java:171)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.resumeOnEventExecutor(SslHandler.java:1820)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.access$2000(SslHandler.java:1711)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner$2.run(SslHandler.java:1872)
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:388)
	at java.base/sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:271)
	at java.base/sun.security.validator.Validator.validate(Validator.java:256)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:284)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:144)
	at io.netty.handler.ssl.EnhancingX509ExtendedTrustManager.checkServerTrusted(EnhancingX509ExtendedTrustManager.java:69)
	at io.netty.handler.ssl.ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerifyCallback.verify(ReferenceCountedOpenSslClientContext.java:235)
	at io.netty.handler.ssl.ReferenceCountedOpenSslContext$AbstractCertificateVerifier.verify(ReferenceCountedOpenSslContext.java:790)
	at io.netty.internal.tcnative.CertificateVerifierTask.runTask(CertificateVerifierTask.java:36)
	at io.netty.internal.tcnative.SSLTask.run(SSLTask.java:48)
	at io.netty.internal.tcnative.SSLTask.run(SSLTask.java:42)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.runAndResetNeedTask(ReferenceCountedOpenSslEngine.java:1534)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.access$700(ReferenceCountedOpenSslEngine.java:96)
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine$TaskDecorator.run(ReferenceCountedOpenSslEngine.java:1509)
	at io.netty.handler.ssl.SslHandler$SslTasksRunner.run(SslHandler.java:1889)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	... 1 common frames omitted
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:146)
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:127)
	at java.base/java.security.cert.CertPathBuilder.build(CertPathBuilder.java:297)
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:383)
	... 17 common frames omitted
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.500 s -- in org.apache.arrow.driver.jdbc.ConnectionTlsTest
[INFO] Running org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandlerBuilderTest
05:32:24.853 [main] INFO  o.a.a.d.jdbc.FlightServerTestRule - Started org.apache.arrow.flight.FlightServer as org.apache.arrow.flight.FlightServer@531ec978
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s -- in org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandlerBuilderTest
[INFO] Running org.apache.arrow.driver.jdbc.client.utils.ClientAuthenticationUtilsTest

@lidavidm
Copy link
Member

ConnectionTlsTest.testGetAuthenticatedEncryptedConnectionWithKeyStoreBadPassword

seems expected?

@vibhatha
Copy link
Collaborator

@lidavidm actually I am not sure. Not very familar with this part of the code. I was thinking I am missing some certification configuration locally.

@lidavidm
Copy link
Member

Read the name of the test

lidavidm pushed a commit that referenced this issue Jan 23, 2024
…9529)

### Rationale for this change

This PR fixes the warnings generated by the errorprone library. 

### What changes are included in this PR?

Updating the code to remove warnings. 

Covered modules
- [x] algorithm
- [x] compression
- [x] flight
- [x] tools
- [x] vector 

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

No
* Closes: #39330

Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 16.0.0 milestone Jan 23, 2024
@pitrou pitrou modified the milestones: 16.0.0, 15.0.1 Feb 14, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…gs (apache#39529)

### Rationale for this change

This PR fixes the warnings generated by the errorprone library. 

### What changes are included in this PR?

Updating the code to remove warnings. 

Covered modules
- [x] algorithm
- [x] compression
- [x] flight
- [x] tools
- [x] vector 

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

No
* Closes: apache#39330

Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
…gs (apache#39529)

### Rationale for this change

This PR fixes the warnings generated by the errorprone library. 

### What changes are included in this PR?

Updating the code to remove warnings. 

Covered modules
- [x] algorithm
- [x] compression
- [x] flight
- [x] tools
- [x] vector 

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

No
* Closes: apache#39330

Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
…gs (apache#39529)

### Rationale for this change

This PR fixes the warnings generated by the errorprone library. 

### What changes are included in this PR?

Updating the code to remove warnings. 

Covered modules
- [x] algorithm
- [x] compression
- [x] flight
- [x] tools
- [x] vector 

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

No
* Closes: apache#39330

Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants