Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmitWarningsOnPlaceholders("age") (#1997) #1999

Open
wants to merge 1 commit into
base: PG14
Choose a base branch
from

Conversation

shinyaaa
Copy link
Contributor

@shinyaaa shinyaaa commented Aug 1, 2024

Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".

Warnings are issued when PostgreSQL starts and when SET statements are executed.

When PostgreSQL starts

2024-08-01 18:32:31.220 JST [2039799] WARNING: invalid configuration parameter name "age.invalid_parameter", removing it

When SET statement is executed

ERROR: invalid configuration parameter name "age.invalid_parameter"
DETAIL: "age" is a reserved prefix.

Regression tests were added.

@github-actions github-actions bot added the PG14 PostgreSQL14 label Aug 1, 2024
@shinyaaa shinyaaa force-pushed the add-emit-warnings-on-placeholders-pg14 branch from 7536f96 to af309b2 Compare August 2, 2024 12:36
@shinyaaa shinyaaa changed the title Add emit warnings on placeholders (#1997) Add EmitWarningsOnPlaceholders("age") (#1997) Aug 5, 2024
@shinyaaa shinyaaa force-pushed the add-emit-warnings-on-placeholders-pg14 branch from af309b2 to e341dd9 Compare August 7, 2024 01:20
@jrgemignani
Copy link
Contributor

jrgemignani commented Aug 7, 2024

@shinyaaa There appears to be an issue with the build regression for this one :( Please look into it when you have an opportunity -

image

@shinyaaa shinyaaa force-pushed the add-emit-warnings-on-placeholders-pg14 branch from e341dd9 to 868c166 Compare August 9, 2024 00:16
Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".
Warnings are issued when PostgreSQL starts.

When PostgreSQL starts
```
2024-08-01 18:32:31.220 JST [2039799] WARNING: invalid configuration parameter name "age.invalid_parameter", removing it
```
@shinyaaa shinyaaa force-pushed the add-emit-warnings-on-placeholders-pg14 branch from 868c166 to c98feb3 Compare August 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG14 PostgreSQL14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants