-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARTEMIS-4545 Allow node ID to be configured #4951
base: main
Are you sure you want to change the base?
Conversation
Have you seen: Line 171 in 5766225
with the zk locker we can have peer brokers that coordinate on a shared node id. it is called the coordinator-id in the zk activation config, but ends up as the node-id. With the potential for unknown backups with replication, the node id has to be reset. However this new config could make it simpler for pure peers, where there is no replication b/c the it is non persistent or uses a shared store. I guess we need to allow these to coexist or document that they must be used independently. |
Another use case is jdbc, it currently uses a new uuid as the node id, it too could benefit from a shared identity, allowing a restart/reconnect of an existing lock owner to retain a valid lease. At the moment, any restart results in a a full lease expiry because the node id is not consistent. |
Thanks for your feedback @gtully If I am not mistaken the first case should be addressed already, where the coordination-id takes precedence over the configured nodeID. It should be verified by: I will take a look at the JDBC case, thanks! |
@gtully Do you know of any current test that demonstrates (or at least includes) having to wait for a lease expiry for the JDBC case? |
This turned out to be quite a bit more involved than what I originally anticipated, please let me know if anything is missing or is otherwise looking strange