Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses real stored count in check_storage() #2944

Merged

Conversation

brooksprumo
Copy link

Problem

In check_storage(), it uses the approximate store count to get the total number of accounts stored in an append vec. There's already a better dcou fn for getting the total number of accounts: accounts_count().

We can use accounts_count() in check_storage(), and also be explicit about how many alive vs total accounts we expect.

Summary of Changes

Use accounts_count() in check_storage(), and also be explicit about how many alive vs total accounts we expect.

@brooksprumo brooksprumo self-assigned this Sep 16, 2024
@brooksprumo brooksprumo marked this pull request as ready for review September 16, 2024 21:20
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just testing

@brooksprumo brooksprumo merged commit 037838a into anza-xyz:master Sep 19, 2024
40 checks passed
@brooksprumo brooksprumo deleted the approx-store-count/check-storage branch September 19, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants