-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store-histogram: skip not found file meta #2906
Conversation
ad7a60b
to
b2b08b6
Compare
Co-authored-by: Brooks <brooks@prumo.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to request review again. need to format the file. |
this is fine. I'd rather it just keep running and log failing files. If you are running this while a validator is running, it could clean something away and delete it after getting the dir but before opening the file. |
Ah. Make sense. That explains when I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
store-histogram crash on not found file meta.
this can actually happen.
#2906 (comment)
Summary of Changes
instead of crash when file meta is not found, we skip them and continue.
Fixes #