Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts-db: Add scan tests to cover bad accounts storage files #2123

Merged
merged 6 commits into from
Jul 21, 2024
Merged

Accounts-db: Add scan tests to cover bad accounts storage files #2123

merged 6 commits into from
Jul 21, 2024

Conversation

HaoranYi
Copy link

@HaoranYi HaoranYi commented Jul 12, 2024 •
edited
Loading

Problem

Tests changes splitted from #2093

Summary of Changes

Add tests coverage for scan* functions

Fixes #

@HaoranYi HaoranYi mentioned this pull request Jul 12, 2024
Merged
@HaoranYi HaoranYi changed the title Add scan tests Accounts-db: Add scan tests Jul 12, 2024
@HaoranYi HaoranYi changed the title Accounts-db: Add scan tests Accounts-db: Add scan tests to cover bad accounts storage files Jul 12, 2024
@HaoranYi
Copy link
Author

We will wait for #2123 to merge, in order to get the same error message for overflow tests.

@HaoranYi HaoranYi force-pushed the accounts-db/scan_test branch 3 times, most recently from 3a9e4a8 to 87ef110 Compare July 13, 2024 12:59
@HaoranYi
Copy link
Author

We will wait for #2123 to merge, in order to get the same error message for overflow tests.

Rebased and picked up #2123.

brooksprumo
brooksprumo reviewed Jul 15, 2024
View reviewed changes
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
brooksprumo
brooksprumo reviewed Jul 18, 2024
View reviewed changes
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
brooksprumo
brooksprumo reviewed Jul 19, 2024
View reviewed changes
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last nits then I think it's good to go!

accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Outdated Show resolved Hide resolved
HaoranYi and others added 3 commits July 19, 2024 18:35
@HaoranYi @brooksprumo
Update accounts-db/src/append_vec.rs
03c1535 
Co-authored-by: Brooks <brooks@prumo.org>
@HaoranYi @brooksprumo
Update accounts-db/src/append_vec.rs
0dd029b 
Co-authored-by: Brooks <brooks@prumo.org>
pr comments
72fe2b6
brooksprumo
brooksprumo approved these changes Jul 20, 2024
View reviewed changes
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thanks for adding these tests!

@HaoranYi HaoranYi merged commit 70efe81 into anza-xyz:master Jul 21, 2024
41 checks passed
@HaoranYi HaoranYi deleted the accounts-db/scan_test branch July 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoranYi @brooksprumo