-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move secp256k1_recover to its own crate #1656
Conversation
The circular dependency check is failing but the premise of the check is wrong. It's complaining about the recommended way to activate a feature in tests: https://stackoverflow.com/questions/68618789/is-it-possible-to-enable-a-rust-feature-only-in-test Update: turns out I don't need that to make the tests pass so we can worry about it another time |
Coverage failure means nothing to me: |
facb162
to
caf046e
Compare
0d42f21
to
9415e53
Compare
9415e53
to
d0e6bf3
Compare
d0e6bf3
to
b1cf5e9
Compare
2975708
to
920ca4a
Compare
@samkim-crypto after some frozen-abi adventures, all CI except for crate-check is now passing |
2d2ab60
to
75b79e7
Compare
…es-for-publishing.py
This reverts commit 86e8671.
75b79e7
to
3f33a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks a lot for all these changes!
Problem
libsecp256k1 is a heavy dependency and the use case is niche
Summary of Changes
Moves secp256k1_recover out of solana-program and into its own crate. Re-export with deprecation notice