frozen-abi: Remove proc_macro_hygiene featurization #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 838 838
Lines 225941 225941
=========================================
- Hits 184945 184926 -19
- Misses 40996 41015 +19 |
ryoqun
reviewed
Mar 6, 2024
Comment on lines
-20
to
-24
| // See https://github.com/solana-labs/solana/issues/11055 | ||
| // We may be running the custom `rust-bpf-builder` toolchain, | ||
| // which currently needs `#![feature(proc_macro_hygiene)]` to | ||
| // be applied. | ||
| println!("cargo:rustc-cfg=RUSTC_NEEDS_PROC_MACRO_HYGIENE"); |
There was a problem hiding this comment.
seems this originated at solana-labs#10905 (comment)
ryoqun
approved these changes
Mar 6, 2024
No issue, I noticed it while reviewing solana-program/address-lookup-table#7 and wondered if it was still needed. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's still usage of an additional
proc_macro_hygienefeature in frozen-abi and a few of its dependencies, but the issue referenced in the comment, solana-labs#11055, has been long resolved.Summary of Changes
I'm not sure if this is OK, but I wanted to get the discussion started with a simple PR to remove this usage everywhere. If I'm missing something, I'll be happy to close the PR!
Fixes #