-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate svg instead of mermaid #913
Conversation
ashwinsajiv
commented
Jun 24, 2020
- Generates svg files instead of mermaid files while generating diagrams through the command line
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
+ Coverage 83.35% 84.03% +0.67%
==========================================
Files 73 74 +1
Lines 10609 10301 -308
==========================================
- Hits 8843 8656 -187
+ Misses 1432 1335 -97
+ Partials 334 310 -24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came across a few issues in mermaid-go that I think we should resolve first before we merge this in. Lets hold off for a moment?
Co-authored-by: Jack Zheng <j.zheng@live.com.au>
Co-authored-by: Jack Zheng <j.zheng@live.com.au>
@ashwinsajiv Okay the bug has been fixed in mermaid-go anz-bank/mermaid-go#1, can you update the import to That should update the |
-go mod clean up