Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate svg instead of mermaid #913

Closed
wants to merge 9 commits into from

Conversation

ashwinsajiv
Copy link
Contributor

  • Generates svg files instead of mermaid files while generating diagrams through the command line

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #913 into master will increase coverage by 0.67%.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   83.35%   84.03%   +0.67%     
==========================================
  Files          73       74       +1     
  Lines       10609    10301     -308     
==========================================
- Hits         8843     8656     -187     
+ Misses       1432     1335      -97     
+ Partials      334      310      -24     
Impacted Files Coverage Δ
pkg/pbutil/output.go 76.00% <ø> (-0.48%) ⬇️
pkg/parse/listener_impl.go 89.50% <54.54%> (-0.01%) ⬇️
pkg/importer/importer.go 63.15% <63.15%> (ø)
pkg/mod/gomod.go 73.68% <66.66%> (+1.27%) ⬆️
pkg/parse/parse.go 83.47% <69.56%> (-0.50%) ⬇️
pkg/mod/module.go 66.66% <72.72%> (+0.95%) ⬆️
pkg/importer/formats.go 77.27% <77.27%> (ø)
pkg/importer/openapi.go 81.73% <80.71%> (-7.72%) ⬇️
pkg/importer/swagger.go 81.48% <88.88%> (+1.88%) ⬆️
pkg/importer/xsd.go 91.01% <95.23%> (+0.64%) ⬆️
... and 13 more

Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cmd/sysl/cmd_diagram.go Outdated Show resolved Hide resolved
cmd/sysl/cmd_diagram.go Outdated Show resolved Hide resolved
@cuminandpaprika cuminandpaprika self-requested a review June 24, 2020 23:24
Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came across a few issues in mermaid-go that I think we should resolve first before we merge this in. Lets hold off for a moment?

ashwinsajiv and others added 3 commits June 25, 2020 11:46
Co-authored-by: Jack Zheng <j.zheng@live.com.au>
Co-authored-by: Jack Zheng <j.zheng@live.com.au>
@cuminandpaprika
Copy link
Contributor

@ashwinsajiv Okay the bug has been fixed in mermaid-go anz-bank/mermaid-go#1, can you update the import to github.com/anz-bank/mermaid-go/mermaid from "github.com/joshcarp/mermaid-go/mermaid" in cmd/sysl/cmd_diagram.go and then run go mod tidy?

That should update thego.mod file with the new dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants