Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnymailWebhookValidationFailure on some events #397

Closed
wants to merge 1 commit into from

Conversation

MikeVL
Copy link

@MikeVL MikeVL commented Aug 31, 2024

No description provided.

@medmunds
Copy link
Contributor

medmunds commented Sep 2, 2024

@MikeVL thank you for the contribution. Could you please open an issue describing the problem this is trying to fix?

(I can try to guess: it seems like Unisender Go uses a fragile webhook authentication methodology that depends on implementation specific details of JSON serialization. But it would be helpful to confirm this and get more details.)

@MikeVL
Copy link
Author

MikeVL commented Sep 3, 2024

@medmunds On some events the auth digest check fails. Probably because during deserialization and serialization json keys are sorted in a different order.

Now this code works fine in my production.

@medmunds
Copy link
Contributor

medmunds commented Sep 8, 2024

@MikeVL thanks for this.

In trying to update the tests for this PR, I discovered several other problems with the current Unisender Go webhook implementation. I've opened a new PR #401 covering all of them, including a version of your fix from here.

@medmunds medmunds closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants