Resend: new ESP #341
Merged
Resend: new ESP #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medmunds
force-pushed
the
feature/resend-esp
branch
3 times, most recently
from
462fbc6
to
60d4691
Compare
|
Hoping to get some updates from Resend about issues with display-names before merging, but this is pretty much complete. If anyone wants to test Resend now, you can install django-anymail directly from this PR branch: python -m pip install \
'git+https://github.com/anymail/django-anymail.git@feature/resend-esp'Anymail Resend docs are in this PR, if you don't mind reading around the Sphinx markup that GitHub doesn't support. (Properly formatted docs will be on anymail.dev once merged.) |
Add a workaround that allows non-ascii characters in `from_email` by avoiding standards complaint RFC 2047 encoding. Also add undocumented setting to disable workarounds if/when Resend's API accepts standard address formats.
Resend pushed new API that allows commas and parens in display names (but still has trouble with " < etc.)
As of ~2023-10-20 API update, custom header values must be strings. (Numbers are not coerced to strings, and multivalue headers via arrays are no longer allowed.)
medmunds
force-pushed
the
feature/resend-esp
branch
from
60d4691
to
b105c51
Compare
For from display-names, use correct RFC 5322 quoting and escaping, but with raw Unicode text (skip RFC 2047 encoding for non-ASCII chars). As of the latest API updates, Resend correctly handles some quoting, but rejects or randomly rewrites the display name in other cases. (But there's nothing we can do about those cases; hopefully the API continues to improve.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Resend.com - see #329