Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aria): 设置无障碍标签 #3656

Merged
merged 2 commits into from
Oct 9, 2021
Merged

feat(aria): 设置无障碍标签 #3656

merged 2 commits into from
Oct 9, 2021

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Oct 8, 2021 •
edited
Loading

Checklist
  • 按照标准 为 G2 增加 aria 方法，设置无障碍标签。
  • 目前只能让开发者手动来写图表描述。未来需要研究如何根据图形语法配置自动生成图表描述信息。
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@hustcc hustcc requested a review from visiky October 8, 2021 05:35
@github-actions
Copy link

github-actions bot commented Oct 8, 2021 •
edited
Loading

🎊 PR Preview 7d69af7 has been successfully built and deployed to https://antvis-G2-preview-pr-3656.surge.sh?type=diff&date=2021-10-11

🕐 Build time: 134.797s

🤖 By surge-preview

@hustcc hustcc requested a review from pearmini October 8, 2021 05:47
pearmini
pearmini previously approved these changes Oct 8, 2021
View reviewed changes
visiky
visiky previously approved these changes Oct 8, 2021
View reviewed changes
@hustcc hustcc dismissed stale reviews from visiky and pearmini via 0f751e7 October 8, 2021 11:56
@hustcc hustcc requested review from visiky and pearmini October 8, 2021 11:57
@hustcc
Copy link
Member Author

hustcc commented Oct 8, 2021

前面忘了增加文档，已经增加。

@hustcc hustcc merged commit 7d69af7 into master Oct 9, 2021
@hustcc hustcc deleted the feat-aria-label branch October 9, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky Awaiting requested review from visiky

@pearmini pearmini Awaiting requested review from pearmini

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustcc @visiky @pearmini