Updating scala documentation to be more idiomatic and work with ST4 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Sounds ok to me, but could you guys sign the contributors.txt file? Thanks! |
…code in doc/faq/object-models.md with a version that is functional with Scala case classes. Co-authored-by: James Mahler <jmahler@andrew.cmu.edu> Co-authored-by: Yang LI <zjzsliyang@gmail.com> Co-authored-by: dyuan0226 <dyuan1@andrew.cmu.edu>
…to main doc directory Co-authored-by: Yang LI <zjzsliyang@gmail.com> Co-authored-by: James Mahler <jmahler@andrew.cmu.edu> Co-authored-by: mma-tapad <marvin.ma@tapad.com>
Yep, we've signed the contributors.txt file! Let us know if there's anything else we should do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing scala adaptor documentation is written in a Java-like way and not the way typical Scala would be written. Additionally, the ST calls it uses have been refactored/deprecated. This PR updates the documentation.
We would also like to change the filename (and references to this file) from
object-models.mdto something more descriptive likescala-model-adaptor.md. We'll make the appropriate commits if we get the OK.Co-authored-by: James Mahler jmahler@andrew.cmu.edu
Co-authored-by: Yang LI zjzsliyang@gmail.com
Co-authored-by: dyuan0226 dyuan1@andrew.cmu.edu