Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: ColorPicker reset logic #50148

Merged
merged 2 commits into from
Jul 30, 2024
Merged

enhance: ColorPicker reset logic #50148

merged 2 commits into from
Jul 30, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 30, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #50127

💡 Background and solution

当从 transparent 切换到实色时,优先填充一个 hsb filled 色值以提升用户体验。

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: https://ant.design/changelog
Language Changelog
🇺🇸 English Optimize ColorPicker when selecting a color from the transparent state, it defaults to using a bright color instead of black color to enhance the user interaction experience.
🇨🇳 Chinese 优化 ColorPicker 当从 transparent 状态进行颜色选取时,默认使用亮色以代替原本的纯黑色以提升用户交互体验。

Copy link

stackblitz bot commented Jul 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 30, 2024

👁 Visual Regression Report for PR #50148 Failed ❌

🎯 Target branch: master (fd6b3f1)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
color-picker-allowClear.compact.png color-picker-allowClear.compact.png color-picker-allowClear.compact.png color-picker-allowClear.compact.png
color-picker-allowClear.compact.png color-picker-allowClear.compact.png color-picker-allowClear.compact.css-var.png color-picker-allowClear.compact.css-var.png
color-picker-base.compact.png color-picker-base.compact.png color-picker-base.compact.png color-picker-base.compact.png
color-picker-base.compact.png color-picker-base.compact.png color-picker-base.compact.css-var.png color-picker-base.compact.css-var.png
color-picker-change-completed.compact.png color-picker-change-completed.compact.png color-picker-change-completed.compact.png color-picker-change-completed.compact.png
color-picker-change-completed.compact.png color-picker-change-completed.compact.png color-picker-change-completed.compact.css-var.png color-picker-change-completed.compact.css-var.png
color-picker-controlled.compact.png color-picker-controlled.compact.png color-picker-controlled.compact.png color-picker-controlled.compact.png
color-picker-controlled.compact.png color-picker-controlled.compact.png color-picker-controlled.compact.css-var.png color-picker-controlled.compact.css-var.png
color-picker-disabled-alpha.compact.png color-picker-disabled-alpha.compact.png color-picker-disabled-alpha.compact.png color-picker-disabled-alpha.compact.png
color-picker-disabled-alpha.compact.png color-picker-disabled-alpha.compact.png color-picker-disabled-alpha.compact.css-var.png color-picker-disabled-alpha.compact.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Preview is ready

Copy link

socket-security bot commented Jul 30, 2024

Copy link
Contributor

github-actions bot commented Jul 30, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 346.09 KB (+4.27 KB 🔺)
./dist/antd-with-locales.min.js 396.72 KB (+4.37 KB 🔺)

Copy link

pkg-pr-new bot commented Jul 30, 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (fd6b3f1) to head (865cba3).
Report is 28 commits behind head on feature.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature   #50148      +/-   ##
===========================================
- Coverage    99.99%   99.99%   -0.01%     
===========================================
  Files          753      751       -2     
  Lines        13821    13135     -686     
  Branches      3658     3426     -232     
===========================================
- Hits         13820    13134     -686     
  Misses           1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

feature 分支的 commit 带过来了

@zombieJ zombieJ changed the base branch from master to feature July 30, 2024 09:16
@zombieJ
Copy link
Member Author

zombieJ commented Jul 30, 2024

feature 分支的 commit 带过来了

thx,我搞错基线了

@li-jia-nan
Copy link
Member

大了 4.27kb 是合理的吗

@li-jia-nan
Copy link
Member

哦,不对,这个应该是上一个提交的 size,最新的还没跑出来

@zombieJ
Copy link
Member Author

zombieJ commented Jul 30, 2024

哦,不对,这个应该是上一个提交的 size,最新的还没跑出来

看起来是没有更新,不过你看看代码。相信这个尺寸是误报吧。2333

@zombieJ zombieJ merged commit aebc23f into feature Jul 30, 2024
80 checks passed
@zombieJ zombieJ deleted the enhance-color-picker branch July 30, 2024 09:39
@zombieJ zombieJ restored the enhance-color-picker branch August 2, 2024 07:13
@afc163 afc163 deleted the enhance-color-picker branch August 5, 2024 06:50
linxianxi pushed a commit to linxianxi/ant-design that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants