Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_runner contains deprecated call to be removed in 2.9 #55316

Closed
sivel opened this issue Apr 15, 2019 · 3 comments · Fixed by #55395
Closed

gitlab_runner contains deprecated call to be removed in 2.9 #55316

sivel opened this issue Apr 15, 2019 · 3 comments · Fixed by #55395
Assignees
@sivel
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. gitlab Gitlab community has_pr This issue has an associated PR. module This issue/PR relates to a module. P2 Priority 2 - Issue Blocks Release source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.

Comments

@sivel
Copy link
Member

sivel commented Apr 15, 2019 •
edited
Loading

SUMMARY

gitlab_runner contains call to Display.deprecated or AnsibleModule.deprecate and is scheduled for removal

lib/ansible/modules/source_control/gitlab_runner.py:291:4: ansible-deprecated-version Deprecated version (2.1) found in call to Display.deprecated or AnsibleModule.deprecate
ISSUE TYPE
  • Bug Report
COMPONENT NAME
lib/ansible/modules/source_control/gitlab_runner.py
ANSIBLE VERSION
2.9
CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

N/A

EXPECTED RESULTS

N/A

ACTUAL RESULTS

N/A
@sivel sivel added the deprecated This issue/PR relates to a deprecated module. label Apr 15, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

cc @Lunik @SamyCoenen @Shaps @dj-wasabi @jlozadad @marwatk @waheedi
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. gitlab Gitlab community module This issue/PR relates to a module. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. and removed deprecated This issue/PR relates to a deprecated module. labels Apr 15, 2019
@sivel sivel added the P2 Priority 2 - Issue Blocks Release label Apr 15, 2019
@Lunik Lunik mentioned this issue Apr 16, 2019
Closed
@sivel
Copy link
Member Author

sivel commented Apr 16, 2019

The issue here is that the version passed to module.deprecate is the float value 2.10 and not a string "2.10".

As such, the float is converted to 2.1

@sivel sivel mentioned this issue Apr 16, 2019
Merged
sivel added a commit to sivel/ansible that referenced this issue Apr 16, 2019
@sivel
Version in deprecate calls should be a string. Fixes ansible#55312. F…
139d9db 
…ixes ansible#55313. Fixes ansible#55314. Fixes ansible#55315. Fixes ansible#55316. Fixes ansible#55317.
@sivel sivel self-assigned this Apr 16, 2019
@sivel sivel added the has_pr This issue has an associated PR. label Apr 16, 2019
sivel added a commit to sivel/ansible that referenced this issue Apr 16, 2019
@sivel
[stable-2.8] Version in deprecate calls should be a string (ansible#5…
f571a71 
…5395)

* Version in deprecate calls should be a string. Fixes ansible#55312. Fixes ansible#55313. Fixes ansible#55314. Fixes ansible#55315. Fixes ansible#55316. Fixes ansible#55317.

* Add changelog fragment
(cherry picked from commit ca83a5c)

Co-authored-by: Matt Martz <matt@sivel.net>
@sivel sivel mentioned this issue Apr 16, 2019
Merged
sivel added a commit to sivel/ansible that referenced this issue Apr 16, 2019
@sivel
Version in deprecate calls should be a string (ansible#55395)
ca83a5c 
* Version in deprecate calls should be a string. Fixes ansible#55312. Fixes ansible#55313. Fixes ansible#55314. Fixes ansible#55315. Fixes ansible#55316. Fixes ansible#55317.

* Add changelog fragment
abadger pushed a commit that referenced this issue Apr 16, 2019
@sivel @abadger
[stable-2.8] Version in deprecate calls should be a string (#55395)
ffa7eaa 
* Version in deprecate calls should be a string. Fixes #55312. Fixes #55313. Fixes #55314. Fixes #55315. Fixes #55316. Fixes #55317.

* Add changelog fragment
(cherry picked from commit ca83a5c)

Co-authored-by: Matt Martz <matt@sivel.net>
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
bcoca pushed a commit to bcoca/ansible that referenced this issue Feb 21, 2020
@sivel @bcoca
Version in deprecate calls should be a string (ansible#55395)
1bcbc8b 
* Version in deprecate calls should be a string. Fixes ansible#55312. Fixes ansible#55313. Fixes ansible#55314. Fixes ansible#55315. Fixes ansible#55316. Fixes ansible#55317.

* Add changelog fragment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sivel sivel

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. gitlab Gitlab community has_pr This issue has an associated PR. module This issue/PR relates to a module. P2 Priority 2 - Issue Blocks Release source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version in deprecate calls should be a string sivel/ansible
2 participants
@sivel @ansibot