-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fact gathering module for amq #145
Merged
guidograzioli
merged 12 commits into
ansible-middleware:main
from
guidograzioli:activemq_jolokia_facts_module
Aug 12, 2024
Merged
Add fact gathering module for amq #145
guidograzioli
merged 12 commits into
ansible-middleware:main
from
guidograzioli:activemq_jolokia_facts_module
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
minor_changes
New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
label
Aug 12, 2024
guidograzioli
force-pushed
the
activemq_jolokia_facts_module
branch
from
August 12, 2024 11:39
0c48228
to
c3bb913
Compare
guidograzioli
force-pushed
the
activemq_jolokia_facts_module
branch
from
August 12, 2024 11:45
e5fb104
to
4fe7674
Compare
rpelisse
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot a typo in the doc, but apart from that LGTM 👌
plugins/modules/activemq_facts.py
Outdated
type: complex | ||
contains: | ||
activemq: | ||
description: THe factual representation of an activemq instance configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe => The
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
minor_changes
New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new module calls into the jolokia API and returns activemq configuration / runtime info as Ansible facts.
Sample usage:
returns: