Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.3 and warnings #219

Merged
merged 16 commits into from
Jul 13, 2022
Merged

4.2.3 and warnings #219

merged 16 commits into from
Jul 13, 2022

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Jul 13, 2022

Overall Review of Changes:
Update to 4.2.3 and standardise the warning messages
added comments around lifecylce of branches

Enhancements:
4.2.3 extended across all logrotate files
Warning message start brought inline
New Warning count at end of run stating how many and which controls need to be manually reviewed
e.g.


TASK [MPG/OS/Linux/REMEDIATE/RHEL8-CIS : Output Warning count and control IDs affected] *************************************************************************************************************************************************
ok: [rhel80_efi] => {
    "msg": "You have 9 warning(s) that require investigating that are related to the following benchmark ID(s)  + ['rule_1.2.4'] + ['rule_2.4'] + [ 'rule_3.4.1.6' ] + [ 'rule_4.2.3' ] + [ 'rule_6.1.1' ] + [ 'rule_6.2.2' ] + [ 'rule_6.2.3' ] + [ 'rule_6.2.4' ] + [ 'rule_6.2.5' ]"
}

PLAY RECAP ************************************************************************************************************************************************************************************************************************************************************
rhel80_efi                 : ok=313  changed=5    unreachable=0    failed=0    skipped=121  rescued=0    ignored=0 

How has this been tested?:
Manually

uk-bolly and others added 16 commits July 6, 2022 14:55
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
…o issue_215

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 22cd0fa into devel Jul 13, 2022
@uk-bolly uk-bolly deleted the 4.2.3_and_warnings branch July 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants