Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra quotes that break check mode #142

Conversation

ChandlerSwift
Copy link
Contributor

@ChandlerSwift ChandlerSwift commented Oct 13, 2021

Overall Review of Changes:
Fixes syntax error causing #141

Issue Fixes:
Fixes #141

How has this been tested?:
Ran ansible in check mode, worked fine.

Fixes ansible-lockdown#141

Signed-off-by: Chandler Swift <chandler+pearson@chandlerswift.com>
uk-bolly added a commit that referenced this pull request Dec 15, 2021
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly mentioned this pull request Dec 15, 2021
uk-bolly added a commit that referenced this pull request Dec 21, 2021
Audit script
Overall Review of Changes:
Addition of audit script
Many issues resolved and added to the release

Issue Fixes:
#138
#139
#140
#141
#142
#143
#144
#146
#147

Enhancements:

Addition of audit updates
Now consistent metadata
Inline with other os agnostic variables for audit
if run manually or via ansible
removal of included goss module no longer required
@uk-bolly uk-bolly self-assigned this Dec 27, 2021
@uk-bolly
Copy link
Member

Hi @ChandlerSwift

Thank you for taking the time to raise these issues and solution your time and contribution is appreciated. There has a been a new release to devel recently which should address this issue.
We are currently working on a new workflow to make these PRs more seamless.

Thank you once again for your feedback

uk-bolly

@uk-bolly
Copy link
Member

uk-bolly commented Jan 4, 2022

Closing request as now in devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running in check mode fails on task 6.2.20
2 participants