Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lint workflow #6

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Fixes lint workflow #6

merged 7 commits into from
Aug 31, 2022

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Aug 5, 2022

Overall Review of Changes:
Fixes for newer updates to amazon linux 2

Issue Fixes:
#1
thanks to @andrew-aitkin
#2
#3

Enhancements:
prereq check rewritten for the new version of python now installed
lint tidy up
new workflow with improved speed

How has this been tested?:
Manually and pipelin

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link

@andrew-aiken andrew-aiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@georgenalen georgenalen merged commit 9382e83 into devel Aug 31, 2022
@uk-bolly uk-bolly deleted the fixes_lint_workflow branch March 3, 2023 08:42
@uk-bolly uk-bolly mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants