Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #138/b14ca9f2 backport][stable-1] fix missing check_mode #139

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 10, 2023

This is a backport of PR #138 as merged into main (b14ca9f).

SUMMARY

Fixes #137
Fixes #131

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxysql_manage_config

* fix missing check_mode

* #131 add --changed

* rework

* try to fix path

* remove debug output

(cherry picked from commit b14ca9f)
@patchback patchback bot mentioned this pull request Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #139 (5bd3722) into stable-1 (5dc30b7) will increase coverage by 1.36%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##           stable-1     #139      +/-   ##
============================================
+ Coverage     75.14%   76.51%   +1.36%     
============================================
  Files            10       11       +1     
  Lines          1199     1205       +6     
  Branches        193      194       +1     
============================================
+ Hits            901      922      +21     
+ Misses          221      214       -7     
+ Partials         77       69       -8     
Flag Coverage Δ
integration 75.08% <75.00%> (?)
sanity 19.91% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/proxysql_manage_config.py 71.42% <75.00%> (+0.59%) ⬆️
plugins/doc_fragments/proxysql.py 100.00% <0.00%> (ø)
plugins/modules/proxysql_query_rules.py 71.66% <0.00%> (+0.55%) ⬆️
...ugins/modules/proxysql_query_rules_fast_routing.py 86.74% <0.00%> (+0.60%) ⬆️
plugins/modules/proxysql_mysql_users.py 77.35% <0.00%> (+0.62%) ⬆️
plugins/modules/proxysql_backend_servers.py 71.69% <0.00%> (+0.62%) ⬆️
plugins/modules/proxysql_replication_hostgroups.py 82.39% <0.00%> (+0.70%) ⬆️
plugins/modules/proxysql_scheduler.py 80.31% <0.00%> (+0.78%) ⬆️
plugins/modules/proxysql_global_variables.py 75.30% <0.00%> (+1.23%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@markuman markuman merged commit dd55da4 into stable-1 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant