Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing check_mode #138

Merged
merged 5 commits into from
Jan 10, 2023
Merged

fix missing check_mode #138

merged 5 commits into from
Jan 10, 2023

Conversation

markuman
Copy link
Member

@markuman markuman commented Jan 10, 2023 •
edited
Loading

SUMMARY

Fixes #137
Fixes #131

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxysql_manage_config

@codecov

This comment was marked as off-topic.

Sign in to view
Andersson007
Andersson007 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuman thanks for fixing the bug and improving the CI!

@markuman markuman merged commit b14ca9f into ansible-collections:main Jan 10, 2023
@patchback
Copy link

patchback bot commented Jan 10, 2023 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/b14ca9f272cfe4a658a4c3e33261ee20a0323a9d/pr-138

Backported as #139

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 10, 2023
@markuman @patchback
fix missing check_mode (#138)
5bd3722 
* fix missing check_mode

* #131 add --changed

* rework

* try to fix path

* remove debug output

(cherry picked from commit b14ca9f)
@patchback patchback bot mentioned this pull request Jan 10, 2023
Merged
markuman added a commit that referenced this pull request Jan 10, 2023
@patchback @markuman
fix missing check_mode (#138) (#139)
dd55da4 
* fix missing check_mode

* #131 add --changed

* rework

* try to fix path

* remove debug output

(cherry picked from commit b14ca9f)

Co-authored-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
backport-1
Projects
None yet
Milestone
No milestone
2 participants
@markuman @Andersson007