Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more vars options (token path, token file, validate certs) #95

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes: #94
Related: #86

Adds:

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hashi_vault.py

ADDITIONAL INFORMATION

@briantist briantist added the enhancement New feature or request label Jun 16, 2021
@briantist briantist added this to the v1.2.0 milestone Jun 16, 2021
@briantist briantist self-assigned this Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #95 (b26d64a) into main (80bf8a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files          16       16           
  Lines         783      783           
  Branches       78       78           
=======================================
  Hits          649      649           
  Misses        120      120           
  Partials       14       14           
Impacted Files Coverage Δ
plugins/doc_fragments/connection.py 100.00% <ø> (ø)
plugins/lookup/hashi_vault.py 63.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bf8a2...b26d64a. Read the comment docs.

@briantist
Copy link
Collaborator Author

cc @danielmotaleite

@briantist briantist merged commit 5a71552 into ansible-collections:main Jun 16, 2021
@briantist briantist moved this from In progress to Done in Environment Variable Standardization Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add ansible_hashi_vault_token_file and ansible_hashi_vault_token_path variables
3 participants