-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashi_vault - add retries option to allow for retrying failed requests #71
Conversation
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 83.01% 83.52% +0.50%
==========================================
Files 16 16
Lines 789 892 +103
Branches 78 87 +9
==========================================
+ Hits 655 745 +90
- Misses 120 129 +9
- Partials 14 18 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to run pip install antsibull && antsibull-lint collection-docs .
in a new workflow to add basic linting for the docs.
(I only looked at the documentation.)
It looks I've gotten about all the review I'm gonna get on this one. In addition to tests added here, I've run other local manual tests. I learned some things with that, that I hope to port over to CI at some point, but it's going to require some more of the test improvement work to be done. It's pretty exciting nonetheless, looking at using MMock to support some advanced testing scenarios that are going to be difficult with a real Vault server alone (intermittent failing connections, maybe AWS/Azure/GCP/etc. backend testing without setting up the actual backend 3rd party service, etc.) by mocking various endpoints. In the meantime, I'll merge this is in so we can get it released. |
SUMMARY
Closes #58
Adds
retries
option which enables retrying failed requests withurllib3.Retry
.Also adds
retry_action
to control whether or not to emit warnings when a request is retried.This PR also adds the start of a collection docsite, with a User Guide that goes into detail on the retry support.
ISSUE TYPE
COMPONENT NAME
hashi_vault
ADDITIONAL INFORMATION