Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashi_vault - fix userpass auth method #68

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

briantist
Copy link
Collaborator

@briantist briantist commented Mar 18, 2021

SUMMARY

Fixes #66

Tests are going to be more work since none exist yet, tracking that in #67 .

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

hashi_vault

ADDITIONAL INFORMATION

@briantist briantist added the bug Something isn't working label Mar 18, 2021
@briantist briantist added this to the v1.1.3 milestone Mar 18, 2021
@briantist briantist self-assigned this Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #68 (490d87e) into main (089c63b) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   82.70%   82.59%   -0.11%     
==========================================
  Files          13       13              
  Lines         769      770       +1     
  Branches       78       78              
==========================================
  Hits          636      636              
- Misses        119      120       +1     
  Partials       14       14              
Impacted Files Coverage Δ
plugins/lookup/hashi_vault.py 63.15% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089c63b...490d87e. Read the comment docs.

@briantist
Copy link
Collaborator Author

@joao-p-marques confirmed (thank you!) in #66 that:

  • the older hvac is not affected so userpass works in that
  • that this PR works with later hvac

@briantist briantist merged commit 17ee3b0 into ansible-collections:main Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashi_vault - Can't login using username/password (userpass auth method)
1 participant