-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for core changes: stop stripping Unsafe, adapt adapter to config manager changes #416
Fix for core changes: stop stripping Unsafe, adapt adapter to config manager changes #416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 98.85% 98.83% -0.03%
==========================================
Files 82 79 -3
Lines 4282 4197 -85
Branches 841 825 -16
==========================================
- Hits 4233 4148 -85
Misses 39 39
Partials 10 10 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
9.2.0 Major Changes ------------- community.docker ~~~~~~~~~~~~~~~~ - The ``community.docker`` collection now depends on the ``community.library_inventory_filtering_v1`` collection. This utility collection provides host filtering functionality for inventory plugins. If you use the Ansible community package, both collections are included and you do not have to do anything special. If you install the collection with ``ansible-galaxy collection install``, it will be installed automatically. If you install the collection by copying the files of the collection to a place where ansible-core can find it, for example by cloning the git repository, you need to make sure that you also have to install the dependency if you are using the inventory plugins (ansible-collections/community.docker#698). community.hashi_vault ~~~~~~~~~~~~~~~~~~~~~ - requirements - the ``requests`` package which is required by ``hvac`` now has a more restrictive range for this collection in certain use cases due to breaking security changes in ``ansible-core`` that were backported (ansible-collections/community.hashi_vault#416). dellemc.openmanage ~~~~~~~~~~~~~~~~~~ - All OME modules are enhanced to support the environment variables `OME_USERNAME` and `OME_PASSWORD` as fallback for credentials. - All iDRAC and Redfish modules are enhanced to support the environment variables `IDRAC_USERNAME` and `IDRAC_PASSWORD` as fallback for credentials. - idrac_certificates - The module is enhanced to support the import and export of `CUSTOMCERTIFICATE`. - idrac_gather_facts - This role is enhanced to support secure boot. - idrac_license - The module is introduced to configure iDRAC licenses. infoblox.nios_modules ~~~~~~~~~~~~~~~~~~~~~ - Upgrade Ansible version support from 2.13 to 2.16. - Upgrade Python version support from 3.8 to 3.10.
Changes to
requests
requirementrequests
package which is required byhvac
now has a more restrictive range for this collection due to breaking security changes inansible-core
that were backported. These changes were backported to core 2.14, 2.15, and 2.16.token
andnamespace
.token
must be of type str or bytes, not <class 'ansible.utils.unsafe_proxy.AnsibleUnsafeText'> #289requests>=2.28,<2.29
requests
updated their overly restrictive type requirement, so as of this PR, we will no longer attempt to strip unsafe.namespace
value with newerrequests
#310Changes related to the option adapter and validation
devel
) changes the way config manager (which is used in plugins) sets options, to now "get" the option before setting it.set_option
/set_options
API in plugins by:raw
)ca_cert
) is supposed to be astr
but internally could be overwritten tostr
orbool
.Other changes
constraints.txt
file we had (for tests) was in the wrong place and was not being used. It's been deleted from the old place and duplicated into the unit and integration tests directories.SUMMARY
Fixes #412
Fixes #417
ISSUE TYPE