Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 changes: split Vault testing, drop core 2.13, add py3.12, bump hvac minimum, add dependabot, more small changes #403

Merged
merged 16 commits into from
Nov 5, 2023

Conversation

briantist
Copy link
Collaborator

@briantist briantist commented Oct 15, 2023

SUMMARY
  • Split integration matrix for Vault versions now that we have more concurrency in GHA
  • Use the correct Vault docker image in integration tests
  • Drop support for core 2.13
  • Add support for Python 3.12
  • Bump minimum hvac version to 1.2.1
  • Fix formatting in user guide requirements
  • Bump actions/checkout to v4 and disable git progress
  • Update release workflow to support galaxy v3
  • Update readme
  • Add dependabot.yml
ISSUE TYPE
  • CI Pull Request

@briantist briantist added the ci Specifically related to the CI on this repo label Oct 15, 2023
@briantist briantist added this to the v6.0.0 milestone Oct 15, 2023
@briantist briantist self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a72430) 98.87% compared to head (2bab75c) 98.85%.

❗ Current head 2bab75c differs from pull request most recent head a308a54. Consider uploading reports for the commit a308a54 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   98.87%   98.85%   -0.03%     
==========================================
  Files          82       82              
  Lines        4282     4282              
  Branches      466      841     +375     
==========================================
- Hits         4234     4233       -1     
  Misses         39       39              
- Partials        9       10       +1     
Flag Coverage Δ
env_docker-default 98.85% <ø> (-0.03%) ⬇️
integration 81.05% <ø> (ø)
sanity 39.25% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 84.03% <ø> (-0.06%) ⬇️
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.25% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 56.07% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.11% <ø> (ø)
target_lookup_vault_list 90.00% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.02% <ø> (ø)
target_module_utils 97.48% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 56.93% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_kv2_write 57.32% <ø> (ø)
target_module_vault_list 85.71% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.11% <ø> (ø)
target_modules 82.35% <ø> (ø)
units 95.57% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briantist briantist added documentation Improvements or additions to documentation removal Remove or disable something breaking-change Describes current or future breaking changes labels Oct 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main

@briantist briantist changed the title Split Vault testing v6 changes: split Vault testing, drop core 2.13, add py3.12, bump hvac minimum, more small changes Oct 15, 2023
@briantist briantist changed the title v6 changes: split Vault testing, drop core 2.13, add py3.12, bump hvac minimum, more small changes v6 changes: split Vault testing, drop core 2.13, add py3.12, bump hvac minimum, add dependabot, more small changes Oct 15, 2023
@briantist briantist marked this pull request as ready for review October 15, 2023 19:45
@briantist briantist merged commit 693646a into ansible-collections:main Nov 5, 2023
48 checks passed
@briantist briantist deleted the ci/core-vault-python branch November 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Describes current or future breaking changes ci Specifically related to the CI on this repo documentation Improvements or additions to documentation removal Remove or disable something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants