hashi_vault - add AppRole deprecation and fix invalid deprecation logic #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #32
This started out just being a PR to use the newer hvac auth method class for AppRole, and add our deprecation fallback logic.
But I discovered that logic (which I put in place) only actually works on the positive case (the new auth method is available) and actually fails otherwise, so it was never working as intended 🤦♂️.
Took this opportunity to fix that, and make it more pythonic using exception handling instead of
hasattr()
.Tested with multiple versions of hvac locally to ensure it worked right (we don't [yet] test multiple hvac versions in CI).
ISSUE TYPE
COMPONENT NAME
hashi_vault.py
ADDITIONAL INFORMATION