-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_iam auth - rename auth method, add tests #193
aws_iam auth - rename auth method, add tests #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 92.43% 93.96% +1.52%
==========================================
Files 41 41
Lines 1639 1739 +100
Branches 125 135 +10
==========================================
+ Hits 1515 1634 +119
+ Misses 111 91 -20
- Partials 13 14 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5bd76e9
to
9323331
Compare
##Docs Build 📝 Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
SUMMARY
Fixes: #118
This PR contains several changes to AWS auth support:
aws_iam_login
toaws_iam
. This corrects an error that I made when introducing it, including thehvac
"login" convention as part of the auth method name. That is corrected in this PR, in doc fragments, choices, class and file names, etc. The old name will work until3.0.0
when it will be removed, and warning is displayed if the old name is used.aws_iam
auth!ISSUE TYPE
COMPONENT NAME
aws_iam auth
ADDITIONAL INFORMATION
N/A