-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy test setup #191
Remove legacy test setup #191
Conversation
##Docs Build 📝 Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 40 40
Lines 1589 1589
Branches 122 122
=======================================
Hits 1457 1457
Misses 119 119
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
SUMMARY
This PR removes the "legacy" integration test option, that downloaded Vault and tinyproxy locally.
It provided ease of use, where contributors could simply rename the sample integration config and run tests, but it was very slow if you needed to run multiple targets. It's also tough to maintain.
I want to introduce additional software needed, such as MMock, an additional Vault instance or two (Agent mode, perhaps a separate writable instance), toxiproxy, possible an LDAP server, etc. Every one of these would require additional direct install support to continue supporting the legacy mode.
The docker-based localenv is much simpler to add additional software onto, as it's just a matter of additional containers to the config.
This PR also:
ISSUE TYPE
COMPONENT NAME
tests/CI
ADDITIONAL INFORMATION