Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action group #172

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

briantist
Copy link
Collaborator

SUMMARY

Adds an action group for modules in the collection. There's only 1 module right now but several others are planned.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

runtime.yml

ADDITIONAL INFORMATION

N/A

@briantist briantist added the enhancement New feature or request label Nov 2, 2021
@briantist briantist added this to the v1.5.0 milestone Nov 2, 2021
@briantist briantist self-assigned this Nov 2, 2021
@briantist briantist temporarily deployed to docs-build November 2, 2021 19:15 Inactive
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #172 (78f9f02) into main (8d5d5e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          40       40           
  Lines        1587     1587           
  Branches      123      123           
=======================================
  Hits         1455     1455           
  Misses        119      119           
  Partials       13       13           
Flag Coverage Δ
env_docker-default 91.68% <ø> (ø)
integration 75.80% <ø> (ø)
py2.6 36.18% <ø> (ø)
py2.7 83.49% <ø> (ø)
py3.10 90.80% <ø> (ø)
py3.5 83.74% <ø> (ø)
py3.6 83.74% <ø> (ø)
py3.7 83.74% <ø> (ø)
py3.8 90.86% <ø> (ø)
py3.9 90.86% <ø> (ø)
sanity 37.76% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 56.40% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 67.00% <ø> (ø)
target_import 37.76% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.40% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
units 88.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5d5e2...78f9f02. Read the comment docs.

@dmsimard
Copy link

dmsimard commented Nov 2, 2021

@briantist that's a good idea 👍

Will you provide docs or examples how to leverage it like in https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html ?

@briantist
Copy link
Collaborator Author

Will you provide docs or examples how to leverage it like in https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html ?

@dmsimard yeah I have a lot of plans for extended documentation, including having a full section or page for many/most of the common options shared across the collection (so far there's detailed guidance for retries: for example in the docsite). But in trying to work against the deadlines, I will probably defer some of that.

@briantist briantist merged commit d673336 into ansible-collections:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants