Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: add env and ini var for mount_point option #171

Conversation

horazont
Copy link
Contributor

@horazont horazont commented Nov 1, 2021

SUMMARY

This makes most sense; it is part of the credentials needed to
authenticate with vault, e.g. on servers with multiple independent
AppRole mountpoints.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

auth methods

ADDITIONAL INFORMATION

Hopefully self-explanatory, if it is not, please let me know.

@horazont horazont temporarily deployed to docs-build November 1, 2021 10:16 Inactive
@briantist briantist self-assigned this Nov 1, 2021
@briantist briantist added the enhancement New feature or request label Nov 1, 2021
@briantist briantist added this to the v1.5.0 milestone Nov 1, 2021
@briantist
Copy link
Collaborator

Hello @horazont and welcome! Thanks for submitting this.
Please also add a changelog fragment in the format described. You may use auth methods for the scope portion, and the link at the end can point at this PR.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #171 (2c6a957) into main (af71153) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          40       40           
  Lines        1587     1587           
  Branches      123      123           
=======================================
  Hits         1455     1455           
  Misses        119      119           
  Partials       13       13           
Flag Coverage Δ
env_docker-default 91.68% <ø> (ø)
integration 75.80% <ø> (ø)
py2.6 36.18% <ø> (ø)
py2.7 83.49% <ø> (ø)
py3.10 90.80% <ø> (ø)
py3.5 83.74% <ø> (ø)
py3.6 83.74% <ø> (ø)
py3.7 83.74% <ø> (ø)
py3.8 90.86% <ø> (ø)
py3.9 90.86% <ø> (ø)
sanity 37.76% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 56.40% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 67.00% <ø> (ø)
target_import 37.76% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.40% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
units 88.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/auth.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af71153...2c6a957. Read the comment docs.

@horazont horazont force-pushed the feature/auth-mount-point-vars branch from b86b5e6 to a1846bf Compare November 4, 2021 07:30
@horazont horazont temporarily deployed to docs-build November 4, 2021 07:30 Inactive
@horazont
Copy link
Contributor Author

horazont commented Nov 4, 2021

Hi @briantist. Sorry for the late reaction, GitHub email notifications aren't reliable for me because they end up in my private inbox instead of my work inbox for this.

Anyway, am I doing this right? :)

@briantist
Copy link
Collaborator

@horazont please also rebase your branch against the upstream main, as I fixed the issue with the macos CI job failing.

This makes most sense; it is part of the credentials needed to
authenticate with vault, e.g. on servers with multiple independent
AppRole mountpoints.
@horazont horazont force-pushed the feature/auth-mount-point-vars branch from f8f68bf to 2c6a957 Compare November 5, 2021 11:09
@horazont horazont temporarily deployed to docs-build November 5, 2021 13:39 Inactive
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

##Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh

@@ -0,0 +1,2 @@
minor_changes:
- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed up the wording on this 🤦‍♂️ I'm going to merge this and "fix it in post" since I am on a short timeline for the release of 1.5.0 and then 2.0.0.

Suggested change
- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).
- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``ANSIBLE_HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).

@briantist briantist merged commit 8be0541 into ansible-collections:main Nov 5, 2021
briantist added a commit to briantist/community.hashi_vault that referenced this pull request Nov 5, 2021
briantist added a commit that referenced this pull request Nov 5, 2021
* correct changelog wording for #171

* prepare 1.5.0 release

* remove redundant scope in changelog

* release 1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants