Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashi_vault lookup - add timeout connection option #100

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes: #99

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hashi_vault

ADDITIONAL INFORMATION

@briantist briantist added the enhancement New feature or request label Jun 21, 2021
@briantist briantist added this to the v1.3.0 milestone Jun 21, 2021
@briantist briantist self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #100 (21af6ac) into main (88997b7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   82.97%   83.01%   +0.04%     
==========================================
  Files          16       16              
  Lines         787      789       +2     
  Branches       78       78              
==========================================
+ Hits          653      655       +2     
  Misses        120      120              
  Partials       14       14              
Impacted Files Coverage Δ
plugins/doc_fragments/connection.py 100.00% <ø> (ø)
plugins/module_utils/_hashi_vault_common.py 100.00% <100.00%> (ø)
...odule_utils/test_hashi_vault_connection_options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88997b7...21af6ac. Read the comment docs.

@briantist briantist merged commit d597e13 into ansible-collections:main Jun 22, 2021
briantist added a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashi_vault connection - add option to control timeout
3 participants