Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashi_vault - [env] Fix token_file and token_path env vars #15

Closed
briantist opened this issue Dec 6, 2020 · 0 comments · Fixed by #173
Closed

hashi_vault - [env] Fix token_file and token_path env vars #15

briantist opened this issue Dec 6, 2020 · 0 comments · Fixed by #173
Assignees
@briantist
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@briantist
Copy link
Collaborator

briantist commented Dec 6, 2020 •
edited
Loading

SUMMARY

See #10

In ansible-collections/community.general#902 I replaced/added env vars prefixed by VAULT_ to solve the underlying issue, however thinking about that after the fact has led to #10 .

I'm proposing the following:

  • The VAULT_TOKEN_FILE and VAULT_TOKEN_PATH env vars will be deprecated in v0.2.0 and removed in v2.0.0.
  • The ANSIBLE_HASHI_VAULT_TOKEN_FILE and ANSIBLE_HASHI_VAULT_TOKEN_PATH vars will be added in v0.2.0
  • The VAULT_ variants will not be preserved, as they are not currently in use by the Vault CLI for this (or any) purpose; future use would conflict and this should be avoided.

⚠This is a breaking change
📝Impact Notes:

  • Affects users who use VAULT_ prefixed environment variables which are available in the following collections and versions:
    • community.general version 0.2.0 and above
    • community.hashi_vault version 0.1.0
  • Does not affect anyone using INI or direct parameter setting
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

hashi_vault.py

ADDITIONAL INFORMATION
@briantist briantist added the enhancement New feature or request label Dec 6, 2020
@briantist briantist self-assigned this Dec 13, 2020
@briantist briantist added this to the v1.0.0 milestone Dec 13, 2020
briantist added a commit to briantist/community.hashi_vault that referenced this issue Dec 21, 2020
@briantist
Change token_file and toke_path env vars
75ddfba 
- Remove `VAULT_TOKEN_FILE` and `VAULT_TOKEN_PATH` env vars
- Add `ANSIBLE_HASHI_VAULT_TOKEN_FILE` and `ANSIBLE_HASHI_VAULT_TOKEN_PATH` env vars
- Resolves ansible-collections#15
@briantist briantist mentioned this issue Dec 21, 2020
Closed
briantist added a commit to briantist/community.hashi_vault that referenced this issue Dec 21, 2020
@briantist
Change token_file and toke_path env vars
b907fd2 
- Remove `VAULT_TOKEN_FILE` and `VAULT_TOKEN_PATH` env vars
- Add `ANSIBLE_HASHI_VAULT_TOKEN_FILE` and `ANSIBLE_HASHI_VAULT_TOKEN_PATH` env vars
- Resolves ansible-collections#15
@briantist briantist mentioned this issue Dec 23, 2020
Merged
@briantist briantist modified the milestones: v1.0.0, v0.2.0, v2.0.0 Dec 23, 2020
@danielmotaleite danielmotaleite mentioned this issue Jun 15, 2021
Closed
@briantist briantist mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briantist briantist

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

remove deprecated environment variables for 2.0.0 briantist/community.hashi_vault
1 participant
@briantist